Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with token refresh #1555

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Sep 9, 2024

Issue(s)

Description

Presently, we're setting the token to null before trying to refresh. If the refresh token fails for some reason, then due to the conditional check for token (token != null), the refresh won't be re-tried again. With this PR, we're fixing this by avoiding setting it to null before the refresh attempt.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit d86dd05 into master Sep 9, 2024
7 of 8 checks passed
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the ak_fix_refresh_token_retry branch September 9, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants