add hero variant to entries along with hero_ids #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor and small (just 3 lines) change, adding
variant
field to entries for 7.36+ matches.Since odota does processing for public matches, this might not be particularly useful most of the time. But it might be handy as a backup source of information about hero variants (e.g. for matches that might lack this information in the API for some reason, for replays of private matches outside of odota or maybe changed throughout the game potentially?).
The downside is having redundant value in every entry, but it's similar to
hero_id
in this regard.