Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hero variant to entries along with hero_ids #70

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

leamare
Copy link
Contributor

@leamare leamare commented Jun 19, 2024

This is a very minor and small (just 3 lines) change, adding variant field to entries for 7.36+ matches.

Since odota does processing for public matches, this might not be particularly useful most of the time. But it might be handy as a backup source of information about hero variants (e.g. for matches that might lack this information in the API for some reason, for replays of private matches outside of odota or maybe changed throughout the game potentially?).

The downside is having redundant value in every entry, but it's similar to hero_id in this regard.

@howardchung howardchung merged commit c621405 into odota:master Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants