Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wards #56

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Fix wards #56

merged 4 commits into from
Mar 25, 2022

Conversation

builder-247
Copy link
Member

Fixes odota/web#2923

Changes to getPlayerSlotFromEntity:

  • added entity null check
  • attempts to use m_iPlayerID for backward compatibility
  • Now returns null instead of -1 on failure

Related to #55

@builder-247
use getPlayerSlotFromEntity for wards
0e60905
@builder-247
update getPlayerSlotFromEntity
bf4cae3 
* added entity null check
* attempts to use `m_iPlayerID` for backward compatibility 
* Now returns null instead of -1 on failure
@builder-247
remove log
291964e
@builder-247
correct return value
1056bf7
@howardchung howardchung merged commit 904d0f2 into odota:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardchung howardchung howardchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observer wards are not shown in Vision tab
2 participants
@builder-247 @howardchung