Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rank supports 7 star system but app only supports 5 #144

Closed
dkwl93 opened this issue Feb 6, 2019 · 4 comments
Closed

Rank supports 7 star system but app only supports 5 #144

dkwl93 opened this issue Feb 6, 2019 · 4 comments

Comments

@dkwl93
Copy link
Contributor

dkwl93 commented Feb 6, 2019

Rank has 7 stars but app only has 5. App should be updated to reflect new system. Image assets should be imported from the opendota/web repo
@howardchung
Copy link
Member

@Proyoyo? If you're busy I can try to make the change, I don't have a RN dev environment set up though.

@Proyoyo
Copy link
Contributor

Proyoyo commented Feb 7, 2019

I can work on this sometime next week. There's a big release this past month at work so I've been a bit busy.

@dkwl93
Copy link
Contributor Author

dkwl93 commented Feb 8, 2019

HMU @Proyoyo if you don't have the time. I can handle this one too if need be

@Proyoyo
Copy link
Contributor

Proyoyo commented Feb 12, 2019

@dkwl93 Do you mind taking care of this one? I'm still a bit busy this week.

Proyoyo added a commit that referenced this issue Feb 24, 2019
@Proyoyo
Updated rank icons.
016e860 
Fixed OpenDota theme reverse background.
Close #142 & #144.
@Proyoyo Proyoyo closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@howardchung @Proyoyo @dkwl93