Add player/records endpoint #1839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe each record should contain the full match object? |
howardchung
reviewed
Jan 29, 2019
howardchung
reviewed
Jan 29, 2019
| @@ -451,6 +455,29 @@ function getMatchRankTier(match, cb) { | |||
| }); | |||
| } | |||
|
|
|||
| function getPlayerRecords(player, cb) { | |||
There was a problem hiding this comment.
this is going to have to be cached in some way. . . otherwise this one call is making 20+ calls to the database
There was a problem hiding this comment.
Perhaps I should only call the getPlayerMatches function once and then sort the data from there? Or do you have other ideas how this should be handled?
There was a problem hiding this comment.
Yeah, that might be more efficient.
howardchung
reviewed
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow creating records overview on web, similar to dotabuff:
TODO: