Remove destructive assignment for repository #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
pocke
added a commit
to pocke/octokit.rb
that referenced
this pull request
Mar 23, 2017
…s failed Note: Test cases for this PR is failed now. It will be fixed if octokit#876 was merged. Currently, an error message of `Octokit::Repository.new` is unkind. For example: ```ruby Octokit::Repository.new(nil) # => Octokit::InvalidRepository: Invalid Repository. Use user/repo format. ``` If an user want to pass an id(Integer), this message is wrong for the user. This change improves the error message. So, this change makes debugging easier.
|
ping |
|
I think this is a very reasonable change. Some people may be relying on the mutation, which I would consider a bug. My suggestion for this would be to do a patch release with this change. |
3 similar comments
pocke
added a commit
to pocke/octokit.rb
that referenced
this pull request
Jul 14, 2017
…s failed Note: Test cases for this PR is failed now. It will be fixed if octokit#876 was merged. Currently, an error message of `Octokit::Repository.new` is unkind. For example: ```ruby Octokit::Repository.new(nil) # => Octokit::InvalidRepository: Invalid Repository. Use user/repo format. ``` If an user want to pass an id(Integer), this message is wrong for the user. This change improves the error message. So, this change makes debugging easier.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octokit::Repositorybreaks an argument if the argument is a Hash.This change fixes the problem.
Reproduce