Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dependabot and Codespaces secret management #1596

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

kamarcum
Copy link
Contributor

Resolves #1594


Before the change?

  • The endpoints for Codespaces secrets and Dependabot secrets weren't supported.
  • Actions secrets methods had names like get_secret, which is ambiguous now that there are more secret types.

After the change?

  • Now there are 3 flavors of each secret operation, such as get_actions_secret get_codespaces_secret and get_dependabot_secret

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

At the moment, the previous methods such as get_secret are gone. But I suspect we'll be happier if I alias ActionsSecrets to support the old names. I'll update this section if we do that.


@kamarcum kamarcum changed the title More secrets Add support for Dependabot and Codespaces secret management Jul 24, 2023
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kamarcum! I'll get this merged and release a v7.0.0 in the near future.

@kfcampbell kfcampbell mentioned this pull request Jul 27, 2023
5 tasks
@kfcampbell kfcampbell merged commit 8a63254 into octokit:main Jul 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Support for codespaces and dependabot secrets
2 participants