Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SARIF data upload #1586

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Conversation

mathroule
Copy link
Contributor

@mathroule mathroule commented Jun 12, 2023

Resolves #1585


Behavior

Before the change?

  • Uploading SARIF data is not supported

After the change?

Other information

  • Add code scanning cassettes
  • Add Rubocop SARIF fixture

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@mathroule mathroule force-pushed the add-code-scanning branch 4 times, most recently from a175042 to 486b90c Compare June 12, 2023 21:01
@kfcampbell kfcampbell added the Type: Feature New feature or request label Jun 22, 2023
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 3804098 into octokit:main Jun 22, 2023
@mathroule mathroule deleted the add-code-scanning branch June 23, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add support for SARIF data upload
3 participants