[bugfix] Ensures that he API Token in clear text is never present in the error stack trace when set in the URL

[nickfloyd]

Resolves #1559

---

Behavior

Before the change?

• Prior to the change, the api_token that was passed via URI (currently the only way the GitHub REST API accepts this value) was being persisted and sent to STDOUT in the stack trace when errors occurred.

After the change?

• The value of the key from the URL now displays as http://127.0.0.1:8989/setup/api/settings?api_key=(redacted)

Other information

I added tests for the private method.

I have mixed feelings about testing this method from this class like this due to potentially breaking encapsulation, but given the nature of this method and the fact that it is meant to keep secrets out of logs.

I feel like it is worth it and will help us know if something changes in this area.

---

Additional info

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes (Please add the Type: Breaking change label)
• No

If Yes, what's the impact:

• N/A

---

[kfcampbell]

One day our API will accept this in a more secure fashion. Until then, this is a good alternative. Thanks!