-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImGuiTabBarFlags_NoSeparator flag #6820
Conversation
I would rather ensure that style-related parameters are all based on shared Style data rather than per-instance, hence my past answer in the styles you linked above. I believe it can be realized in a more simple manner by:
What do you think? I also agree that in this case Let me know. |
This reverts commit 072308c.
This seems more reasonable and preferable. However, unfortunately, it appears that for detached windows, the pushed colors are not considered. I used the following solution to one of the issues mentioned above: ImGui::PushStyleColor(ImGuiCol_TabActive, ImVec4());
ImGui::PushStyleColor(ImGuiCol_TabUnfocusedActive, ImVec4());
ImGui::DockSpaceOverViewport(..., ...);
ImGui::PopStyleColor(2); Not very familiar with the source code, but my guess is that the detached windows are drawn in "NewFrame" before the user code is called (see "DockContextNewFrameUpdateDocking")~ |
Correct, the solution is currently to modify that style when calling |
What about the top pixel (see the first screenshot here)? |
Presently it is being too distracting to add minor/custom styling features for everything. Best to wait until a larger refactor of the styling system. |
👋.
The problem
Tab bars in dock nodes draw the bottom line (separator). Tabs trim the top and bottom pixels.
The only solution for disabling that I could find was to hide the bottom line (separator) by pushing a transparent color (see #4859, #5022, and #5239). This doesn't remove trimming, leaving 2 pixels of space at the top and bottom, and adds unnecessary calls, "drawing" a transparent line.
The solution
Result
Thanks for your time~