Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z3 4.8.5 package wrt Python2 #24618

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

cmovcc
Copy link

@cmovcc cmovcc commented Oct 10, 2023

This removes Python2 dependencies for this version of z3, that is still used by FStar, although this is hopefully going to change soon, see FStarLang/FStar#2974.
Disclaimer: I only tested x86_64-linux.
cc @R1kM @msprotz @tahina-pro

@mseri
Copy link
Member

mseri commented Oct 10, 2023

Thanks, would you mind releasing this as z3.4.8.5-1 instead?

remove Python2 dependencies
@cmovcc
Copy link
Author

cmovcc commented Oct 11, 2023

Sure! I used z3 4.8.8 and 4.8.9 as examples, as both also have an additional -1 package version. That being said, I did not know whether the available flag should be set to false for z3 4.8.5, it is the case for z3 4.8.9 but not for z3 4.8.8.

@mseri
Copy link
Member

mseri commented Oct 11, 2023

I would not make this unavailable since it should work if python 2 is present

@mseri
Copy link
Member

mseri commented Oct 11, 2023

Thanks!

@mseri mseri merged commit f7ef783 into ocaml:master Oct 11, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants