Serve site from fs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Jul 30, 2021
lib/ocamlorg_web/router.ml
Outdated
| Lwt_io.(with_file ~mode:Input file) (fun channel -> | ||
| let open Lwt.Syntax in | ||
| let* content = Lwt_io.read channel in | ||
| Dream.respond ~headers content)) |
There was a problem hiding this comment.
Isn't Dream.from_filesystem better than constructing a manual response here?
There was a problem hiding this comment.
We need a custom handler because the requested path is not the path of the file we want to serve (i.e. we need to add an index.html if it's not there)
There was a problem hiding this comment.
(The IO code is taken from Dream.from_filesystem)
|
This LGTM if it is ready to go (I'm guessing this is the last thing blocking having continuous deployment via ocurrent deployer?) |
|
Thanks for the review @patricoferris! I think it is, @avsm needed this when working on the deployment. I'll merge now. |
tmattio
pushed a commit
that referenced
this pull request
Sep 14, 2021
add list tutorial and port to mdx
tmattio
pushed a commit
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the v3.ocaml.org static file serving to read the files from the filesystem instead of crunching them at compile time.
The path of the site dir can be set at runtime time with the
OCAMLORG_SITE_DIRenv variable.cc @avsm