Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows install instructions to opam #2658

Merged
merged 11 commits into from
Sep 6, 2024

Conversation

Sudha247
Copy link
Contributor

@cuihtlauac
Copy link
Collaborator

@jonahbeckford: Can you review this please?

@jonahbeckford
Copy link
Contributor

Overall it looks good.

When I tried to install ocamlformat with opam 2.2 (unrelated to this PR), it failed. So it would be good to go through the site and see what works and what doesn't.

@jonahbeckford
Copy link
Contributor

Note: I'll submit a DkML PR for ocaml.org early next week. But it is best to get opam 2.2 properly documented on the website first.

@Sudha247
Copy link
Contributor Author

When I tried to install ocamlformat with opam 2.2 (unrelated to this PR), it failed. So it would be good to go through the site and see what works and what doesn't.

Indeed, I've been making some notes on the state of platform tools on Windows. I'll publish it on gist next week and find a more permanent place for it.

Copy link

@pirbo pirbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sudha247. I'll duplicate my remark that I think we should move fast on this at the price of postponing instruction about the platform which is not there yet (and make our priority number 1 to fix that!)

src/ocamlorg_frontend/pages/install.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/install.eml Show resolved Hide resolved
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you! I agree with @pirbo that it would be better to get a version deployed quickly and then iterate on it - to that end, I'd suggest leaving the updates for 3_01_ocaml_on_windows.md to a subsequent PR.

src/ocamlorg_frontend/pages/install.eml Show resolved Hide resolved
src/ocamlorg_frontend/pages/install.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/install.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/install.eml Outdated Show resolved Hide resolved
src/ocamlorg_frontend/pages/install.eml Outdated Show resolved Hide resolved
@jonahbeckford
Copy link
Contributor

Edit: I'll do a PR to add back in DkML as a secondary option in mid-Sept. I'm +1 for getting this PR merged.

Copy link
Collaborator

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like my previous commit to remove the repeated word was lost somehow, so I made a suggestion to do so this time instead of editing it directly.

@dra27
Copy link
Member

dra27 commented Sep 6, 2024

Is this able to be merged, please - it would be great to have the site up-to-date before tomorrow's ICFP workshop talks!

@cuihtlauac cuihtlauac merged commit 8b92a83 into ocaml:main Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update install instructions on windows
6 participants