Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved defaults and wizard experience for Algolia endpoints #987

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

chuckmeyer
Copy link
Contributor

@chuckmeyer chuckmeyer commented Mar 21, 2024

Description

This improves upon the initial Algolia PR from @sumitsarkar (#933) to use a TMDB index and settings that mirror the Solr and ElasticSearch examples in the tour, and updates the Algolia logo in the Wizard epxerience.

Motivation and Context

This provides a better oboarding experience for users that select Algolia from the wizard.

How Has This Been Tested?

This code has been tested in a local docker instance. I have confirmed the happy paths for Algolia, ElasticSearch, and Solr.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we haven't done much optimization for specific engines in the tour, this is a nice idea...

@epugh
Copy link
Member

epugh commented Mar 27, 2024

I have two small edits, but can't quite get them to push to this PR, so going to merge this and then add them.

@epugh epugh merged commit 7e18be0 into o19s:main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants