Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The frog report #526

Merged
merged 17 commits into from
Jul 11, 2022
Merged

The frog report #526

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2155544
lets communicate how bad our frog problem is
epugh Jun 13, 2022
05b8a57
first cut of frog pond report
epugh Jun 14, 2022
61992af
jshint
epugh Jun 18, 2022
d276565
try and debug pipeline
epugh Jul 5, 2022
15bb31e
issues with procfile?
epugh Jul 5, 2022
4254796
Procfile
epugh Jul 5, 2022
001e395
remove warning we dont need
epugh Jul 5, 2022
86863e8
introduced vega via sprockets
epugh Jul 8, 2022
c06dc12
use sprocket based vega
epugh Jul 8, 2022
925d08d
jshint
epugh Jul 10, 2022
71c291a
rubocop
epugh Jul 10, 2022
42c5d7c
jshint
epugh Jul 10, 2022
c516fbb
report is alive
epugh Jul 10, 2022
98a2f6b
jshint
epugh Jul 10, 2022
ec1904b
small tweaks to text and chart and flip the image
epugh Jul 11, 2022
662379b
base image
epugh Jul 11, 2022
0114527
makes more sense to have it on by default
epugh Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
introduced vega via sprockets
  • Loading branch information
@epugh
epugh committed Jul 8, 2022
commit 86863e8b1df9b6ccfccc2b101a9f2d4b633baf5c
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,5 @@ gem 'omniauth-rails_csrf_protection', '~> 1.0'
gem 'omniauth-google-oauth2', '~> 1.0'

gem 'rails-healthcheck', '~> 1.4'

gem "vega", "~> 0.2.6"
2 changes: 2 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ GEM
concurrent-ruby (~> 1.0)
unicode-display_width (2.0.0)
uniform_notifier (1.14.2)
vega (0.2.6)
warden (1.2.9)
rack (>= 2.0.9)
webmock (3.14.0)
Expand Down Expand Up @@ -444,6 +445,7 @@ DEPENDENCIES
simplecov
terser
turbolinks (~> 5)
vega (~> 0.2.6)
webmock
webpacker (= 5.4.0)

Expand Down
4 changes: 4 additions & 0 deletions app/assets/javascripts/analytics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@
//= require bootstrap/dist/js/bootstrap.bundle
//= require jquery
//= require cookies_eu

//= require vega
//= require vega-lite
//= require vega-embed
4 changes: 0 additions & 4 deletions app/views/layouts/analytics.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@
<%= stylesheet_link_tag 'application', media: 'all' %>
<%= csrf_meta_tags %>
<%= javascript_include_tag 'analytics' %>

<!-- Can't figure out how to include Vega using Sprockets/Webpacker -->
<script src="https://cdn.jsdelivr.net/npm/vega@5"></script>

</head>
<body class="d-flex flex-column h-100">
<header>
Expand Down