use task_name instead of task.name #1224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two sources of task names in
jiant
.task_name
->task
mapping from thetask_config_dict
task.name
, which is derived from the task config.In all parts of the
jiant
training/eval loop, we usetask_name
, including for creating the models. The one exception is the runner calling the model, where we use the task object (and hencetask.name
).To resolve this conflict, we will assign the
task.name = task_name
and throw a warning if they do not agree.