-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic binary eval. #5168
Comments
I will look into this issue. Strahinja [email protected]于2016年7月30日周六 23:15写道:
|
@kilgaloon I cannot reproduce this issue. Here is my test case: https://gist.github.com/ghostoy/183649c64060b088a610ebc142fae3d2 I got |
Can you put for loop in another bin, then try. |
@kilgaloon What do you mean by "another bin"? A third one? |
@ghostoy Yes, put for loop in third bin, lets say main.bin and try it like that |
For me it actually doesn't mather where im doing for loop. im using following snippet of code:
every of this bins have corresponding log depending of their name |
@kilgaloon Could you upload your entire test app as attachment? |
I'll contact you on gitter |
@kilgaloon It's quite late for me. Please send attachment to Github and I'll check it tomorrow. |
Project is kinda big, can you give me some where i can privately share it with you? |
I can confirm that multiple Is there some caching going on with evalNWBin? By the way, I noticed that executing |
I can confirm that also when i start app and momentally open developer console, brhavior will be same like its not included. |
You can send mail to me cong.liux#gmail.com Strahinja [email protected]于2016年8月4日周四 18:38写道:
|
@rogerwang I can reproduce this issue with 0.14.6 and 0.16.0. I've updated my gist @ https://gist.github.com/ghostoy/183649c64060b088a610ebc142fae3d2. Steps to reproduce:
This issue seems to be more easier to reproduce on 0.16.0. On 0.14.6, it only produces the logs from later script, i.e.
And on 0.16.0, it always produces the logs from former script, i.e.
|
Good you reproduced this, one more thing to mention, there is also no difference if you put them in loop or you put them like this (using @ghostoy gist):
When i do this to more bins, same thing happen, first always get evaled n times where n = evalNWBin functions. |
@ghostoy @rogerwang Is fix for this going to happen anytime soon? im just curious. |
@ghostoy Can bins be loaded via http or https urls? |
@mscreenie No. Currently only supports local files. |
Thanks should I open something to request that as a feature? |
@mscreenie Yes, thanks. |
@kilgaloon will fix it soon around 0.17 release, which will happen soon. |
@rogerwang Nice to hear that. Can't wait. |
This is fixed in git and will be available in the next nightly build. The root cause is NW is using previous cache of code. |
Great, nice to hear that, my project has been stalling because of this issue. Can't wait to see this working. Thanks |
I have this issue on 0.14.7 LTS |
I still have this issue on 0.14.7 LTS. Please fix this issue. thanks |
Due to our system to support the xp, we have to use 0.14.7 version, please repair this version as much as possible. |
- Add test for issue nwjs#5168 - This test is failed on v0.16.0, passed on v0.31.3
Hello everyone,
I just noticed that when i try to load binary files dynamicaly, for example, using for loop and looping through some array for example:
var arr = ["home","front"];
for(i=0;i<arr.length;i++) {
require('nw.gui').Window.get().evalNWBin(null, process.cwd() + '/' + arr[i] + '.bin');
}
home.bin get executed twice. It never get to front.bin.
Anyway no mather how much arr is long, first element will be evaled for arr.length times.
OS: Debian Jessie x64
NW: 0.14.6
The text was updated successfully, but these errors were encountered: