Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Spotify app module to support recent versions of Spotify. #7689

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Update Spotify app module to support recent versions of Spotify. #7689

merged 2 commits into from
Nov 23, 2017

Commits on Oct 24, 2017

  1. Update Spotify app module to support recent versions of Spotify. 

    1. Spotify no longer fires focus on objects that die before we can fetch them, so remove the hack which worked around this.
2. Spotify still fires focus on an ancestor window instead of the correct focus. However, the trick we previously used to get the correct focus no longer works. Switch to a new trick which does work.
    @jcsteh
    jcsteh committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    f0551ff View commit details
    Browse the repository at this point in the history

  2. Spotify: Reinstate the hack working around focus objects which die be… 

    …fore we can fetch them.

This happens far less than it does before, but it does still happen in some cases.
For example, it happens when pressing enter on an artist in search results.
    @jcsteh
    jcsteh committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    541e767 View commit details
    Browse the repository at this point in the history