LibLouis 3, UEB table name/file names, and provisions for other enhancements. #6110

josephsl · 2016-06-23T21:57:12Z

What's New entry: in Changes:

- Updated liblouis braille translator to 3.0.0. This includes significant enhancements to Unified English Braille. (#6109, #4194, #6220, #6140)

Fixes #6109. Fixes #4194. Fixes #6220. Fixes #6140.

One of the enhancements in LibLouis 3 is centralized pattern matching and translation routines. Among other things, it allows emphasais to be handled better. Thus add pattern.c to list of files to be compiled as part of compiling NVDA from source, as without this, MS Linker (link.exe) presents unresolved symbol error.

…ccess#4194. As the old uebc-g* tables are no longer maintained, it was decided to use the new en-ueb-g* set. Not only this makes the file names more consistent, it allows exciting changes to be included as part of LibLouis 3.0.0. For string compatibility with old NVDA releases, table name presented to users will still be named Unified English Braille Code grade 1/2, with braille table name entries now mapped under en-ueb-g*.

josephsl · 2016-06-23T22:00:34Z

@jcsteh @dkager

…ss#4194

dkager · 2016-06-24T08:54:42Z

The Dutch table name also changed, and possibly the Norwegian one.
Note that this is an alpha release.

josephsl · 2016-06-24T20:50:28Z

@dkager: Do you know the file names of these tables? I found Norwegian (no-no-comp8) but would like to get a list of file name changes so I can commit them in a single commit. Thanks.

…name for Telugu. re nvaccess#6109. Davy Kager reports that Norwegian table file name has changed (confirmed), thus added the new file name. Telugu: it is actually called 'Telugu', not 'Telegu' accoridng to Wikipedia, table header itself and other sources. No impact for translators as it is just English name that's different.

josephsl · 2016-06-24T21:03:51Z

In case of te-in: it is actualy called Telugu, not Telegu. No impact for translators (just English label has been corrected). Thanks.

derekriemer · 2016-06-24T23:26:19Z

Hey Joseph,

I wouldn't be worried about commit cleanlyness too much, because @jcsteh
squashes them once he commits to master, and you can squash them if you
like before pr.

On 6/24/2016 3:03 PM, Joseph Lee wrote:

In case of te-in: it is actualy called Telugu, not Telegu. No impact
for translators (just English label has been corrected). Thanks.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6110 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFGivbSFq8HwoM1clWD93Ak-ZaAL6tUDks5qPEY4gaJpZM4I9R6q.

Derek Riemer

Department of computer science, third year undergraduate student.
Proud user of the NVDA screen reader.
Open source enthusiast.
Member of Bridge Cu
Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at [email protected] mailto:[email protected]
Phone: (303) 906-2194

dkager · 2016-06-25T09:30:22Z

The Dutch tables are nl-BE-g0.utb (Belgium) and nl-NL-g0.utb (Netherlands).

josephsl · 2016-06-25T09:45:53Z

Hi, how about g1 files? Thanks.

From: Davy Kager [mailto:[email protected]]
Sent: Saturday, June 25, 2016 2:30 AM
To: nvaccess/nvda [email protected]
Cc: Joseph Lee [email protected]; Author [email protected]
Subject: Re: [nvaccess/nvda] LibLouis 3, UEB table name/file names, and provisions for other enhancements. (#6110)

The Dutch tables are nl-BE-g0.utb (Belgium) and nl-NL-g0.utb (Netherlands).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #6110 (comment) , or mute the thread https://github.com/notifications/unsubscribe/AHgLkL-UC10QSSuj6MFTiY8vE61sTgKNks5qPPUwgaJpZM4I9R6q .

dkager · 2016-06-25T11:33:44Z

The table has been renamed.

From: Joseph Lee [mailto:[email protected]]
Sent: Saturday, June 25, 2016 11:46
To: nvaccess/nvda [email protected]
Cc: Davy Kager [email protected]; Mention [email protected]
Subject: Re: [nvaccess/nvda] LibLouis 3, UEB table name/file names, and provisions for other enhancements. (#6110)

Hi, how about g1 files? Thanks.

From: Davy Kager [ mailto:[email protected] mailto:[email protected]]
Sent: Saturday, June 25, 2016 2:30 AM
To: nvaccess/nvda < mailto:[email protected] [email protected]>
Cc: Joseph Lee < mailto:[email protected] [email protected]>; Author < mailto:[email protected] [email protected]>
Subject: Re: [nvaccess/nvda] LibLouis 3, UEB table name/file names, and provisions for other enhancements. (#6110)

The Dutch tables are nl-BE-g0.utb (Belgium) and nl-NL-g0.utb (Netherlands).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub < #6110 (comment) https://github.com/nvaccess/nvda/pull/6110#issuecomment-228526266> , or mute the thread < https://github.com/notifications/unsubscribe/AHgLkL-UC10QSSuj6MFTiY8vE61sTgKNks5qPPUwgaJpZM4I9R6q https://github.com/notifications/unsubscribe/AHgLkL-UC10QSSuj6MFTiY8vE61sTgKNks5qPPUwgaJpZM4I9R6q> .

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #6110 (comment) , or mute the thread https://github.com/notifications/unsubscribe/AC9y8dlF9wWosjCvNWfN0qwDmivOaigDks5qPPjVgaJpZM4I9R6q . https://github.com/notifications/beacon/AC9y8c3uNa6jz7EIykKzmZvY0bbkJ7HGks5qPPjVgaJpZM4I9R6q.gif

jcsteh · 2016-07-04T03:22:55Z

The Dutch tables are nl-BE-g0.utb (Belgium) and nl-NL-g0.utb (Netherlands).

Ug. As is far too often the case in liblouis land, this is ridiculously confusing. The old tables still exist... but now we have these new ones.

How is anyone supposed to know which tables to use?
Why the rename? If these supersede the old ones, why not just replace the old ones?
What do we call these? Currently, NVDA calls nl-NL-g1.ctb "Dutch (Netherlands) grade 1". Should this now be grade 0? Or does Dutch only have one grade and we should just drop the "grade 1" bit?
Is this computer braille, uncontracted braille or contracted braille? I assume the last.

…nvaccess#6109

dkager · 2016-07-04T05:23:43Z

Why the rename? If these supersede the old ones, why not just replace the old ones?

I thought they had been replaced. Something to look at.

What do we call these?

Dutch only has one grade, so dropping the "grade 1" in the name sounds fine. This is uncontracted literary braille.

josephsl · 2016-07-04T05:42:45Z

Hi,

@dkager: Thanks for the answer. Will apply it.

For other table maintainers: I think now is the time to tell us which tables are which, especially those that were modified (not due to opcode changes). Thanks.

According to Davy Kager, there is really one braille code for Dutch (no separate grade 0 nor grade 1). Thus: * Dutch (Netherlands) Grade 1 -> Dutch (Netherlands) * Duethc (Belgium) grade 1 -> Duethc (Belgium) Also, the old g0 tables are incompatible iwth new optocdes introduced as part of LibLouis 3 (grade 1 tables use the new ones).

LeonarddeR · 2016-07-04T05:49:43Z

What do we call these?





  Dutch only has one grade, so dropping the "grade 1" in the name
    sounds fine. This is uncontracted literary braille.


Don't we also have a Dutch computer braille code, even though it
isn't in liblouis? Honestly, I think removing the grade from the
name can cause confusion at some point.

josephsl · 2016-07-04T06:03:36Z

For @dkager: @jcsteh is thinking we should use LibLouis's own liblouis.def instead of nVDA's own. Doi you think it's safe to do now, and do you see some benefits and outstanding issues? Thanks.

…n routines that loads liblouis.dll. nvaccess#6109

josephsl · 2016-07-04T06:26:33Z

Hi,

In the end, due to file inclusion issues and build issues on Windows (vanilla Liblouis def), it was decided that NVDA will use its own liblouis.def. Thanks.

jcsteh · 2016-07-04T06:57:13Z

Merge note: This should not be merged to master until liblouis 3.0.0 final is released. Once that happens, do the following:

Update the submodule.
Update the liblouis version in readme.md.

What's New entry: in Changes:

- Updated liblouis braille translator to 3.0.0. (#6109, #4194)
 - If you are using either Dutch or Unified English Braille Code tables, you will need to manually select these again from NVDA's Braille Settings dialog.

dkager · 2016-07-04T11:42:55Z

Instead of the NMake file using liblouis.def we should probably have MSVC generate one. This requires some code changes I'll have to discuss with Christian.
Currently you can't compile findTable.c with MSVC, which is why the .def file causes trouble. Not a big fan of gnulib... :)

dkager · 2016-07-04T11:48:09Z

Don't we also have a Dutch computer braille code, even though it isn't in liblouis? Honestly, I think removing the grade from the name can cause confusion at some point.

No, the 2005 braille standard only includes an uncontracted 6-dot code. In the past we had multiple levels of contractions (3 I believe), but now we don't. So this is grade 0, but since there are no other grades we can leave that out IMO.

On a final note, the Netherlands and Belgium tables differ only in some character definitions. The rules are the same for the whole Dutch language region. At some point we wanted to consolidate the two tables, but it hasn't happened yet.

jcsteh · 2016-07-06T03:48:40Z

Merge note: On further reflection and discussion, this should not be merged to master until #6140 (backwards compat for renamed tables) is done.

josephsl · 2016-07-06T04:07:09Z

Hi, first commit on #6140 (for UEB series and Norwegian) will be done tonight, the rest will be done once beta comes out. Thanks.

From: James Teh [mailto:[email protected]]
Sent: Tuesday, July 5, 2016 8:49 PM
To: nvaccess/nvda [email protected]
Cc: Joseph Lee [email protected]; Author [email protected]
Subject: Re: [nvaccess/nvda] LibLouis 3, UEB table name/file names, and provisions for other enhancements. (#6110)

Merge note: On further reflection and discussion, this should not be merged to master until #6140 #6140 (backwards compat for renamed tables) is done.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #6110 (comment) , or mute the thread https://github.com/notifications/unsubscribe/AHgLkGhakDDDT0icElbl2X8Sf7SPuZJ2ks5qSyWagaJpZM4I9R6q .

…w filenames. re nvaccess#6140. Given that people would be surprised if some tables would revert back to defaults, it would be handy to provide a short migration routine to map old table filenames to new ones. Thus, a tempoary routine and a map is introduced to handle it (to be removed at a future date).

More table renames for Danish (6-dot series) and Dutch, along with entries for them in migration map.

jcsteh · 2016-08-08T06:45:54Z

I want to get this into 2016.3, so in the interest of speed, I've made a few tiny changes myself (rather than going back and forth with a tiny review).

jcsteh · 2016-09-26T22:50:57Z

@michaelDCurran, can you please review these commits? I reviewed most of this, but then made some minor tweaks myself in the interest of speed when I was trying to get this into 2016.3 (a decision we obviously reversed). So, my small tweaks should probably be reviewed.

michaelDCurran · 2016-09-26T23:25:27Z

I am happy with these 4 commits.

josephsl added 2 commits June 23, 2016 13:53

LibLouis 3/UEB support: correct name for UEB grade 1 table. re nvacce…

d2a68a9

…ss#4194

josephsl added 2 commits July 3, 2016 20:30

Upgrade to LibLouis 3.0.0 alpha 2

5bd3b17

LibLouis 3: Make sure to export lou_checkTable (function name change). …

d89810f

…nvaccess#6109

LibLouis 3: add lou_getTable back in, as it might be needed by certai…

1d1ed09

…n routines that loads liblouis.dll. nvaccess#6109

jcsteh added a commit that referenced this pull request Jul 4, 2016

Incubates #6110

5e4c58c

nvaccessAuto added the incubating label Jul 4, 2016

nvaccessAuto assigned jcsteh Jul 4, 2016

josephsl mentioned this pull request Jul 4, 2016

Table maintenance and name/filename match: keeping track of which is which and weeding out deprecated/historical tables liblouis/liblouis#182

Closed

josephsl mentioned this pull request Jul 5, 2016

Braille/Liblouis 3: provide a way to detect and change table names if old tables are no longer included #6140

Closed

josephsl added 5 commits July 5, 2016 21:20

Merge branch 'master' into i6109

ef7762b

LibLouis 3: more renamed tables. re nvaccess#6140

9ae3ca7

More table renames for Danish (6-dot series) and Dutch, along with entries for them in migration map.

Liblouis 3: Oops, adding comma at the end of map items.

ec6b5f0

liblouis 3: Change filename for Slovak table. re nvaccess#6220

df8e22d

jcsteh added 4 commits September 22, 2016 09:43

Rename map of renamed tables. Avoid unnecessary double hash lookup.

feae150

Update to liblouis 3.0.0 final.

f0e1292

liblouis.def: Add new function added in liblouis 3.0.0 final.

4379a84

Merge branch 'master' into i6109

123b08d

jcsteh assigned michaelDCurran Sep 26, 2016

jcsteh added a commit that referenced this pull request Sep 27, 2016

Incubates #6110. Re issues #6109, #4194, #6220, #6140.

6191725

nvaccessAuto unassigned michaelDCurran Sep 27, 2016

jcsteh merged commit de7bf21 into nvaccess:master Oct 11, 2016

nvaccessAuto removed the incubating label Oct 11, 2016

nvaccessAuto added this to the 2016.4 milestone Oct 11, 2016

josephsl deleted the i6109 branch January 27, 2017 01:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LibLouis 3, UEB table name/file names, and provisions for other enhancements. #6110

LibLouis 3, UEB table name/file names, and provisions for other enhancements. #6110

josephsl commented Jun 23, 2016 •

edited by jcsteh

Loading

josephsl commented Jun 23, 2016

dkager commented Jun 24, 2016

josephsl commented Jun 24, 2016

josephsl commented Jun 24, 2016

derekriemer commented Jun 24, 2016

dkager commented Jun 25, 2016

josephsl commented Jun 25, 2016

dkager commented Jun 25, 2016

jcsteh commented Jul 4, 2016

dkager commented Jul 4, 2016

josephsl commented Jul 4, 2016

LeonarddeR commented Jul 4, 2016

josephsl commented Jul 4, 2016

josephsl commented Jul 4, 2016

jcsteh commented Jul 4, 2016 •

edited

Loading

dkager commented Jul 4, 2016

dkager commented Jul 4, 2016

jcsteh commented Jul 6, 2016

josephsl commented Jul 6, 2016

jcsteh commented Aug 8, 2016

jcsteh commented Sep 26, 2016

michaelDCurran commented Sep 26, 2016

LibLouis 3, UEB table name/file names, and provisions for other enhancements. #6110

LibLouis 3, UEB table name/file names, and provisions for other enhancements. #6110

Conversation

josephsl commented Jun 23, 2016 • edited by jcsteh Loading

josephsl commented Jun 23, 2016

dkager commented Jun 24, 2016

josephsl commented Jun 24, 2016

josephsl commented Jun 24, 2016

derekriemer commented Jun 24, 2016

dkager commented Jun 25, 2016

josephsl commented Jun 25, 2016

dkager commented Jun 25, 2016

jcsteh commented Jul 4, 2016

dkager commented Jul 4, 2016

josephsl commented Jul 4, 2016

LeonarddeR commented Jul 4, 2016

josephsl commented Jul 4, 2016

josephsl commented Jul 4, 2016

jcsteh commented Jul 4, 2016 • edited Loading

dkager commented Jul 4, 2016

dkager commented Jul 4, 2016

jcsteh commented Jul 6, 2016

josephsl commented Jul 6, 2016

jcsteh commented Aug 8, 2016

jcsteh commented Sep 26, 2016

michaelDCurran commented Sep 26, 2016

josephsl commented Jun 23, 2016 •

edited by jcsteh

Loading

jcsteh commented Jul 4, 2016 •

edited

Loading