Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA does not return the sound of the audios to normalized using the voice synthesizer windows one core #7431

Closed
fernando-jose-silva opened this issue Jul 23, 2017 · 2 comments · Fixed by #7463
Assignees
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone

Comments

@fernando-jose-silva
Copy link

I changed the nvda synthesizer to the one-core windows voices and noticed a problem.
When playing a song using any audio player the nvda lowers the sound as long as there is talk, however when the voice for the sound does not return to normalised Audio.
The nvda's hen reduction setting is to redirect sounds when playing speech.
This problem did not occur when using another speech synthesizer as nuance vocalizer exprecive 1.1.
I am with nvda next 14215 and windows 10 15063.483.

@derekriemer
Copy link
Collaborator

@jcsteh

@jcsteh
Copy link
Contributor

jcsteh commented Jul 31, 2017

Confirmed. STR:

  1. Switch to the Windows OneCore Voices synthesiser.
  2. Play some music.
  3. Use NVDA+shift+d to set NVDA's audio ducking mode to "Duck when outputting speech and sounds".
    • Expected: After NVDA finishes speaking, audio should be unducked after a short delay.
    • Actual: NVDA finishes speaking, but audio is never unducked.

I must be missing a call to WavePlayer.idle somewhere.

@jcsteh jcsteh self-assigned this Aug 1, 2017
@jcsteh jcsteh added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Aug 1, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Aug 1, 2017
jcsteh added a commit that referenced this issue Aug 1, 2017
…ality. (issue #7431, PR #7463)

The driver now calls WavePlayer.idle as it should after pushing the last chunk of audio if there is no more speech in the queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants