Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update files for v2.2.1 release #644

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Update files for v2.2.1 release #644

merged 1 commit into from
Aug 30, 2023

Conversation

nuttyartist
Copy link
Owner

@guihkx let me know what do you think.

guihkx
guihkx requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@guihkx guihkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a few minor issues.

I'd like to test something on the debian/changelog.in file, though.

Upon trying to install the .deb package on Ubuntu 20.04 using their app store, the changelog isn't displayed at all:

image

I'm thinking I can maybe get rid of the first 6 lines of that file and see if that fixes it (while simultaneously not breaking anything 🤞).

packaging/linux/debian/changelog.in Outdated Show resolved Hide resolved
packaging/linux/common/notes.appdata.xml.in Outdated Show resolved Hide resolved
packaging/linux/common/notes.appdata.xml.in Outdated Show resolved Hide resolved
@nuttyartist
Copy link
Owner Author

Alrighty, I'll wait fot your test and then I'll commit your changes, thanks for noticing!

@guihkx
Copy link
Collaborator

guihkx commented Aug 30, 2023 •
edited
Loading

Okay, that didn't work at all so it's probably something else I'll have to investigate in another opportunity.

I'll revert my commit and you can finish the PR.

Please squash your next commits into the first one as well. :)

@nuttyartist
Copy link
Owner Author

Done. Let me know if alright. And I'll open a new issue for the .deb changelog problem.

@guihkx
Copy link
Collaborator

guihkx commented Aug 30, 2023

That one typo still remains in notes.appdata.xml.in 😅

@nuttyartist nuttyartist mentioned this pull request Aug 30, 2023
Open
@nuttyartist
Copy link
Owner Author

Whoops. Now?

guihkx
guihkx approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@guihkx guihkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nuttyartist nuttyartist merged commit f847e2a into master Aug 30, 2023
17 checks passed
@guihkx guihkx deleted the release-v2.2.1 branch August 31, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guihkx guihkx guihkx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuttyartist @guihkx