-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Update and build Snap package #630
Conversation
There are some caveats, but overall I consider the snap package usable.
Everytime we push to the main branch (master), Snapcraft automatically triggers a new build using _their_ build system, which is better than GitHub Actions because it supports many CPU architectures. However, we still have to make sure the snap package continues to work, and that's why this commit adds a new CI job for the snap package (amd64 only).
Wow, great job @guihkx! That is so needed. I'll test this tomorrow. |
It's been a while, I know, I was busy working on the new subscription model (soon to be PR) and the Block Editor. But I tested this now, and it works incredibly well! I verified and all the notes from the previous version are migrated succesfully into the new version. Awesome work. So, each push into So I guess we can merge this now but only connect the Ubuntu repo when V2.2.1 is ready (I aim for this Thursday). |
Okay one issue detected, seems like drag and drop doesn't work for some reason. Dragging and dropping notes into folders or regular notes into pinned notes. Can you please check on your end as well? |
Yes, but those builds will be sent to the But once you deem a build "stable", you can to manually promote it to the snaps-promoting.mp4In the video above I just promoted the
Sounds good to me!
Seems to work just fine here. Note pinning: pinning.mp4Note moving: moving.mp4 |
Perfect! Sounds like a good process.
Oh, ok. I wonder why it didn't let me drop, I was using a VM with Ubuntu 23. In any case, I'll merge this now. Thanks! |
This PR updates & builds the snap package for Linux distributions.
How it will work:
Once this PR is merged, you (@nuttyartist) should login to snapcraft.io and connect your GitHub account and this repository there. Once that is done, every time we push something into the
master
branch, their build system will automatically build a snap package for the following CPU architectures:amd64
arm64
armhf
ppc64el
I also added a new build job to our own Linux CI, which will provide a single snap package, for amd64 CPUs. That's done to help ensure our snap package won't break that easily on changes coming from a pull request, for example. This also has the obvious benefit of making things easier for snap users to test changes coming from said pull requests.
How you can test the snap package right now:
snap install ./notes_*.snap --dangerous
snap run notes
Closes #185
Closes #501
Closes #579