feat: enable edge-level kill switch to drop messages when buffer is full, for the non-reduce forwarder #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keran Yang <[email protected]>
whynowy
reviewed
Mar 24, 2023
pkg/sinks/udsink/sink.go
Outdated
| @@ -78,7 +78,7 @@ func NewUserDefinedSink(vertex *dfv1.Vertex, fromBuffer isb.BufferReader, fetchW | |||
| return nil, fmt.Errorf("failed to create gRPC client, %w", err) | |||
| } | |||
| s.udsink = udsink | |||
| isdf, err := forward.NewInterStepDataForward(vertex, fromBuffer, map[string]isb.BufferWriter{vertex.GetToBuffers()[0].Name: s}, forward.All, applier.Terminal, fetchWatermark, publishWatermark, forwardOpts...) | |||
| isdf, err := forward.NewInterStepDataForward(vertex, fromBuffer, map[string]isb.BufferWriter{vertex.GetToBuffers()[0].Name: s}, forward.All, map[string]string{vertex.GetToBuffers()[0].Name: dfv1.RetryUntilSuccess}, applier.Terminal, fetchWatermark, publishWatermark, forwardOpts...) | |||
There was a problem hiding this comment.
Is there a way to make the new arg an option?
There was a problem hiding this comment.
Addressed by moving the OnFullWritingStrategy to the writer itself. Was able to bring changed files from 53 to 42.
Signed-off-by: Keran Yang <[email protected]>
|
Next Step
|
whynowy
reviewed
Mar 28, 2023
pkg/apis/numaflow/v1alpha1/const.go
Outdated
| @@ -122,6 +125,10 @@ const ( | |||
| DefaultBufferUsageLimit = 0.8 | |||
| DefaultReadBatchSize = 500 | |||
|
|
|||
| // Edge-level specification to define the writing behaviour when the ToBuffer is full | |||
There was a problem hiding this comment.
Minor - These definitions could stay in the edge_types.go.
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
whynowy
reviewed
Mar 28, 2023
pkg/apis/numaflow/v1alpha1/const.go
Outdated
| @@ -24,6 +24,8 @@ import ( | |||
| "k8s.io/apimachinery/pkg/api/resource" | |||
| ) | |||
|
|
|||
| type BufferFullWritingStrategy string | |||
pkg/forward/forward.go
Outdated
| for idx, msg := range messages { | ||
| if err := errs[idx]; err != nil { | ||
| // ATM there are no user defined errors during write, all are InternalErrors. | ||
| if ok := errors.As(err, &isb.NoRetryableBufferWriteErr{}); ok { |
Signed-off-by: Keran Yang <[email protected]>
whynowy
reviewed
Mar 28, 2023
pkg/apis/numaflow/v1alpha1/const.go
Outdated
| @@ -122,6 +122,9 @@ const ( | |||
| DefaultBufferUsageLimit = 0.8 | |||
| DefaultReadBatchSize = 500 | |||
|
|
|||
| RetryUntilSuccess BufferFullWritingStrategy = "retryUntilSuccess" | |||
Signed-off-by: Keran Yang <[email protected]>
whynowy
pushed a commit
that referenced
this pull request
Apr 3, 2023
…ull, for the non-reduce forwarder (#634) Introduce a new pipeline edge-level specification to define write behaviours when a buffer is full. Signed-off-by: Keran Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mappart of issue kill switch to drop messages when buffer.isFull == true #524I will create follow up PRs for reduce forwarder once this one gets approved.