Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generator based on ticker #2126

Merged
merged 10 commits into from
Oct 7, 2024
Merged

feat: generator based on ticker #2126

merged 10 commits into from
Oct 7, 2024

Conversation

vigith
Copy link
Member

@vigith vigith commented Oct 5, 2024

fixes: #2125

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 96.78899% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.37%. Comparing base (06515a2) to head (90c791c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/source/generator.rs 96.69% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2126       +/-   ##
===========================================
- Coverage   64.02%   53.37%   -10.66%     
===========================================
  Files         325      327        +2     
  Lines       31239    37748     +6509     
===========================================
+ Hits        20002    20148      +146     
- Misses      10195    16558     +6363     
  Partials     1042     1042               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith requested review from BulkBeing and yhl25 October 6, 2024 00:58
@vigith vigith marked this pull request as ready for review October 6, 2024 02:31
@vigith vigith requested a review from whynowy as a code owner October 6, 2024 02:31
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Comment on lines 279 to 281

pub(crate) struct GeneratorLagReader {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LagReader should be cloneable.

Signed-off-by: Vigith Maurice <[email protected]>
@yhl25 yhl25 merged commit 3182db3 into main Oct 7, 2024
27 of 28 checks passed
@yhl25 yhl25 deleted the tickgen branch October 7, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement tickgen using source trait
2 participants