Pass build type to injection attributes #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkoch
reviewed
Oct 23, 2018
| @@ -22,6 +23,13 @@ namespace Nuke.Common.Execution | |||
| public abstract class InjectionAttributeBase : Attribute | |||
| { | |||
| [CanBeNull] | |||
| public abstract object GetValue(string memberName, Type memberType); | |||
| [Obsolete("Use GetValue(string memberName, Type memberType, MemberInfo memberInfo) instead.", error: true)] | |||
There was a problem hiding this comment.
It's probably not called from user code, so won't have any effect. Imo, just remove.
matkoch
reviewed
Oct 23, 2018
| @@ -17,6 +17,7 @@ public static void InjectValues(NukeBuild build) | |||
| var injectionMembers = build.GetInjectionMembers() | |||
| .OrderByDescending(x => x.GetCustomAttribute<ParameterAttribute>() != null); | |||
|
|
|||
| var buildType = build.GetType(); | |||
arodus
force-pushed
the
feature/attribute-injection-improvement
branch
from
a27015a
to
ffe0007
Compare
matkoch
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.