Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.8.0 #150

Merged
merged 26 commits into from
Feb 14, 2019
Merged

6.8.0 #150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
671cad1
[email protected]
zkat Jan 24, 2019
89b23a5
doc: use const in lib/fetch-package-metadata.md (#120)
watilde Jan 29, 2019
4970d55
misc: replace ronn with marked-man (#126)
watilde Jan 29, 2019
d9b6090
Reduce work to test if executable ends with a 'g'. (#138)
elidoran Jan 29, 2019
cdb0592
test(maketest): Fix common.npm callback arguments (#144)
larsgw Jan 29, 2019
91314e7
install/dedupe: fix hoisting of packages with peerDeps (#147)
sokra Jan 29, 2019
25573e9
ls: show installed but unmet peer deps (#145)
larsgw Jan 29, 2019
3663cde
doc: update package.json docs to include repository.directory details…
greysteil Jan 29, 2019
ce2c4bd
token: use figgy-config to make sure extra opts are there (#149)
zkat Jan 30, 2019
95ca1ae
[email protected]
Jan 30, 2019
dacc47d
chore: add changelog for v6.8.0
Jan 30, 2019
f28a94c
update AUTHORS
Jan 31, 2019
309260d
6.8.0-next.0
Jan 31, 2019
3c22d1a
access: ls-collaborators is ok with non-scoped (#151)
zkat Feb 4, 2019
322fef4
[email protected]
Feb 6, 2019
32d34c0
[email protected]
Feb 6, 2019
f54bf9e
chore: update changelog for 6.8.0
Feb 6, 2019
7c62cde
6.8.0-next.1
Feb 6, 2019
d513709
Fix issue with sub folder local references (#86)
jtwebman Feb 7, 2019
7b87710
chore: update changelog for 6.8.0
Feb 7, 2019
b436cb0
update AUTHORS
Feb 7, 2019
26b768d
6.8.0-next.2
Feb 7, 2019
0c97036
Revert "install/dedupe: fix hoisting of packages with peerDeps (#147)…
zkat Feb 12, 2019
338571c
[email protected]
zkat Feb 12, 2019
c7da272
chore: update changelog for final 6.8.0 release
Feb 13, 2019
67142b3
6.8.0
Feb 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
access: ls-collaborators is ok with non-scoped (#151)
  • Loading branch information
zkat authored and aeschright committed Feb 4, 2019
commit 3c22d1a35878f73c0af8ea5968b962a85a1a9b84
2 changes: 1 addition & 1 deletion lib/access.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ access['ls-packages'] = access.lsPackages = ([owner], opts) => {
}

access['ls-collaborators'] = access.lsCollaborators = ([pkg, usr], opts) => {
return getPackage(pkg).then(pkgName =>
return getPackage(pkg, false).then(pkgName =>
libaccess.lsCollaborators(pkgName, usr, opts)
).then(collabs => {
// TODO - print these out nicely (breaking change)
Expand Down
28 changes: 28 additions & 0 deletions test/tap/access.js
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,34 @@ test('npm access ls-collaborators on package', function (t) {
)
})

test('npm access ls-collaborators on unscoped', function (t) {
var serverCollaborators = {
'myorg:myteam': 'write',
'myorg:anotherteam': 'read'
}
var clientCollaborators = {
'myorg:myteam': 'read-write',
'myorg:anotherteam': 'read-only'
}
server.get(
'/-/package/pkg/collaborators?format=cli'
).reply(200, serverCollaborators)
common.npm(
[
'access',
'ls-collaborators',
'pkg',
'--registry', common.registry
],
{ cwd: pkg },
function (er, code, stdout, stderr) {
t.ifError(er, 'npm access ls-collaborators')
t.same(JSON.parse(stdout), clientCollaborators)
t.end()
}
)
})

test('npm access ls-collaborators on current w/user filter', function (t) {
var serverCollaborators = {
'myorg:myteam': 'write',
Expand Down