Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: match git semver ranges #115

Merged
merged 6 commits into from
Feb 18, 2019
Merged

install: match git semver ranges #115

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12e6e4d
install: match git semver ranges
larsgw Dec 13, 2018
4b46cdf
install: match git semver range and repo
larsgw Jan 18, 2019
1884892
test: matching git semver ranges
larsgw Jan 18, 2019
fd5496d
test: clean dedupe-git-semver
larsgw Jan 20, 2019
a290a67
test: fix dedupe-git-semver
larsgw Jan 20, 2019
a61a02b
test: remove stdout logging
larsgw Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
install: match git semver range and repo
  • Loading branch information
@larsgw
larsgw committed Jan 18, 2019
commit 4b46cdf005bfec6f03471a913794b21534e7b0bd
3 changes: 2 additions & 1 deletion lib/install/deps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ function doesChildVersionMatch (child, requested, requestor) {
}

if (requested.type === 'git' && requested.gitRange) {
const sameRepo = npa(child.package._from).fetchSpec === requested.fetchSpec
try {
return semver.satisfies(child.package.version, requested.gitRange, true)
return sameRepo && semver.satisfies(child.package.version, requested.gitRange, true)
} catch (e) {
return false
}
Expand Down