Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using retrying execution strategy in tests #1244

Closed
roji opened this issue Feb 1, 2020 · 0 comments · Fixed by #1251
Closed

Start using retrying execution strategy in tests #1244

roji opened this issue Feb 1, 2020 · 0 comments · Fixed by #1251
Assignees
@roji
Labels
cleanup test
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Feb 1, 2020 •
edited
Loading

We have some transient failures in tests (seems like the new migrations tests), using a retrying strategy would probably make them go away. This is also the way things execute in the EF Core provider tests.

See

efcore.pg/test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlDbContextOptionsBuilderExtensions.cs

Line 9 in 2127c86

//optionsBuilder.ExecutionStrategy(d => new TestNpgsqlRetryingExecutionStrategy(d));

@roji roji added the test label Feb 1, 2020
@roji roji added this to the 5.0.0 milestone Feb 1, 2020
@roji roji self-assigned this Feb 1, 2020
@roji roji mentioned this issue Feb 1, 2020
Merged
roji added a commit to roji/efcore.pg that referenced this issue Feb 3, 2020
@roji
Execution strategy fixes and sync
a30749c 
Includes test changes done in dotnet/efcore#18691

Tests now run using retrying strategy, hopefully working around the
transient exceptions we're seeing on CI since the migration tests.

Closes npgsql#1244
@roji roji added the cleanup label Feb 3, 2020
@roji roji mentioned this issue Feb 3, 2020
Merged
@roji roji closed this as completed in #1251 Feb 3, 2020
roji added a commit that referenced this issue Feb 3, 2020
@roji
Execution strategy fixes and sync
109c489 
Includes test changes done in dotnet/efcore#18691

Tests now run using retrying strategy, hopefully working around the
transient exceptions we're seeing on CI since the migration tests.

Closes #1244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
cleanup test
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Execution strategy fixes and sync roji/efcore.pg
1 participant
@roji