Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: improve react-component code block #742

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Docs: improve react-component code block #742

merged 1 commit into from
Jun 29, 2022

Conversation

murtuzaalisurti
Copy link
Contributor

  • What kind of change does this PR introduce?

  • Documentation improvement -- Improved the code block regarding react-component in which navigate() function was not defined. Added the useNavigate() hook from react-router-dom.

  • What is the current behavior?

  • The navigate() function is not defined, so the user can get confused.

  • What is the new behavior (if this is a feature change)?

  • Added the useNavigate() hook from react-router-dom.

@vercel
Copy link

vercel bot commented Jun 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 2:43PM (UTC)

scopsy
scopsy approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @murtuzaalisurti ! <3

@scopsy scopsy merged commit 138abf3 into novuhq:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murtuzaalisurti @scopsy