NV 546 fix: clipped blocked html #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-546 Email template is clipped due to large size on G-mail
When sending a simple email message the email is clipped by google due to email size. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
scopsy
approved these changes
Jun 24, 2022
scopsy
reviewed
Jun 24, 2022
| @@ -203,7 +203,7 @@ export class SendMessageEmail extends SendMessageType { | |||
| const messageVariables = contentService.buildMessageVariables(command.payload, subscriber); | |||
| const content: IEmailBlock[] = [...emailChannel.template.content] as IEmailBlock[]; | |||
| for (const block of content) { | |||
| block.content = contentService.replaceVariables(block.content, messageVariables); | |||
| block.content = contentService.replaceVariables(block.content, messageVariables).trim(); | |||
There was a problem hiding this comment.
Maybe worth adding a comment here about why the .trim is important :P @djabarovgeorge
There was a problem hiding this comment.
Probably it worth the commit :)
Will do
|
@scopsy added note, let me know if you think its understandable |
|
@djabarovgeorge Looks good! Let's merge it 🚀 |
scopsy
deleted the
NV-546-Email-template-is-clipped-due-to-large-size-on-G-mail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.