Add dynamic backendUrl in @novu/node #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-379 Add backendUrl optional configuration to @novu/node
Why?To allow our novu/node users to specify their own custom implementation of backend API instead of automatically using our cloud API. How?the second object is optional. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
scopsy
reviewed
May 8, 2022
packages/node/src/lib/novu.ts
Outdated
| super(); | ||
|
|
||
| const backendUrl = config?.backendUrl | ||
| ? config?.backendUrl |
There was a problem hiding this comment.
What do you think, should we append the v1 at the end of the URL?
Suggested change
| ? config?.backendUrl | |
| ? config?.backendUrl + '/v1' |
This way the SDK can manage different versions for himself.
scopsy
approved these changes
May 8, 2022
scopsy
deleted the
NV-379-Add-backendUrl-optional-configuration-to-@novu/node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.