-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bug fixed for add filter button in production #4284
fix: Bug fixed for add filter button in production #4284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjcode99 left you a comment in the original ticket ;)
@LetItRock updated the PR with the latest changes. Please verify it . Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sjcode99 👋
almost there, you are doing great! 🙌 just noticed that we didn't cover all the filter cases, please take a look at the below screenshot ;)
…com/sjcode99/novu into fix/show-filter-modal-in-production
@LetItRock, Ohh!!😮 I have missed this. Changes update, Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sjcode99 looking good! Just a small thing here to fix this un-needed import
@@ -9,6 +9,7 @@ import { DeleteStepButton, FilterButton } from './FilterModal.styles'; | |||
import { OnlineFiltersForms } from './OnlineFiltersForms'; | |||
import { PreviousStepFiltersForm } from './PreviousStepFiltersForm'; | |||
import { useMemo } from 'react'; | |||
import { boolean } from 'zod'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it was imported by a mistake.
@@ -44,7 +44,7 @@ export function StepSettings({ index }: { index: number }) { | |||
onClick={() => { | |||
setFilterOpen(true); | |||
}} | |||
disabled={readonly} | |||
disabled={false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled={false} |
Hey @scopsy, removed the unnecessary import. Please have a look |
Hey @LetItRock @scopsy . Seems my code is not yet merged. can you please help with this merge |
Hey @LetItRock, it's been a long since I created PR and I can still see it's not merged. Is there any issue in the code which needs to be addressed? |
What change does this PR introduce?
This PR fixes the bug for the Add Filter button in production
The change was to enable the add filter button in the production environment.
Fixes #4254