Nv 2781 move auth logic to application generic #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-the-main-repo' into NV-2761-add-google-oauth-support-in-the-system
Base automatically changed from
NV-2762-add-enterprisepackages-submodules-and-folder-to-the-main-repo
to
NV-2706-google-oauth-private-package
August 31, 2023 12:53
LetItRock
approved these changes
Aug 31, 2023
djabarovgeorge
merged commit 0b382d0
into
NV-2706-google-oauth-private-package
12 of 13 checks passed
djabarovgeorge
deleted the
nv-2781-move-auth-logic-to-application-generic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
extract auth logic to application generic.
Why was this change needed?
So we could reuse it in other packages as well.
Other information (Screenshots)