feat(app-generic): add test for add job use case to check the injected queue service #3941
Conversation
| @@ -0,0 +1,77 @@ | |||
| import { Test } from '@nestjs/testing'; | |||
| import { ExecutionDetailsRepository, JobRepository } from '@novu/dal'; | |||
| import { UserSession } from '@novu/testing'; | |||
There was a problem hiding this comment.
there are some unused imports and variables ;)
| it('should instantiate properly the use case', async () => { | ||
| const queueService = useCase.getQueueService(); | ||
|
|
||
| expect(queueService.DEFAULT_ATTEMPTS).toEqual(3); | ||
| expect(queueService.name).toEqual('standard'); | ||
| const { bullMqService } = queueService; | ||
| expect(bullMqService).toBeDefined(); | ||
| expect(await bullMqService.getRunningStatus()).toEqual({ | ||
| queueIsPaused: false, | ||
| queueName: 'standard', | ||
| workerIsRunning: undefined, | ||
| workerName: undefined, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
You've created the test for the AddJob use-case but just checking if the queue is instantiated properly? 🤔
is something missing here?
There was a problem hiding this comment.
I am trying to validate that the queueName used by the BullMqService is the right one for the intentions of AddJob. I am facing problems with the DI on the MemoryDB PR and I am going back and forth from next to that PR to double check I am doing the changes properly.
There was a problem hiding this comment.
If you are facing problems with DI typically it's because few provider instances have the same interface. If that's still a problem maybe you should use the "named" injections.
| public getQueueService(): QueueService { | ||
| return this.queueService; | ||
| } |
There was a problem hiding this comment.
you don't need to expose it this way, in the test you can do (useCase as any).queueService
There was a problem hiding this comment.
Changed the visibility to public readonly as I consider bad advise with hacking the type away as I mentioned in previous PRs.
p-fernandez
force-pushed
the
nv-2676-addjob-use-case-test
branch
from
2d7b22e
to
9b98b29
Compare
What change does this PR introduce?
Adds unit test for AddJob use case.
Why was this change needed?
To validate the QueueService injection in the MemoryDB PR for validation.
Other information (Screenshots)