Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: so activating a provider deactivates novu provider #3871

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: so activating a provider deactivates novu provider #3871

merged 1 commit into from
Jul 28, 2023

Conversation

davidsoderberg
Copy link
Contributor

Why was this change needed?

To disable Novu provider if another provider is activated

p-fernandez
p-fernandez approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟
Now the usefulness of having the separate use case shows up. Well done.

@davidsoderberg davidsoderberg merged commit f6a7676 into nv-2503-store-novu-providers-email-sms-in-the-database Jul 28, 2023
15 checks passed
@davidsoderberg davidsoderberg deleted the fix-update-integration-deactivate-novu-provider branch July 28, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-fernandez p-fernandez p-fernandez approved these changes

Assignees
No one assigned
Labels
@novu/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsoderberg @p-fernandez