feat: add feature flag check for deactive integrations #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2417 Remove the "Active" toggle behavior on the API
What?Currently, when a new provider is connected, we are disabling all the other existing providers. This is not the anticipated behaviour from the system, as we want to allow multiple providers from the same channel inside Novu. Definition of Done
|
|
WIP right now |
p-fernandez
reviewed
Jun 19, 2023
apps/api/src/app/integrations/usecases/deactivate-integration/deactivate-integration.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/deactivate-integration/deactivate-integration.usecase.ts
Outdated
Show resolved
Hide resolved
p-fernandez
reviewed
Jun 19, 2023
LetItRock
reviewed
Jun 19, 2023
apps/api/src/app/integrations/usecases/deactivate-integration/deactivate-integration.usecase.ts
Show resolved
Hide resolved
p-fernandez
reviewed
Jun 20, 2023
apps/api/src/app/integrations/e2e/deactivate-integration.e2e.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/integrations/e2e/deactivate-integration.e2e.ts
Outdated
Show resolved
Hide resolved
LetItRock
approved these changes
Jun 20, 2023
davidsoderberg
merged commit b541b80
into
nv-2429-create-new-integrations-page-feature-flag
davidsoderberg
deleted the
nv-2417-remove-the-active-toggle-behavior-on-the-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Feature flag check for deactive integrations.
Why was this change needed?
So we do not keep all integrations active for users that should not have the new multi-provider configuration.