Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support serving uploaded files from CDN #2513

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

JoeyEamigh
Copy link
Contributor

What change does this PR introduce?

This PR adds the optional environment variable CDN_URL to the .example.env file as well as code that checks if the CDN_URL variable is set during a file upload request, and if so returns the path relative to the CDN_URL instead of the S3, GC, or Azure bucket endpoint.

Why was this change needed?

Closes #2512

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🔥

@scopsy scopsy merged commit 5d4f2c5 into novuhq:next Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Serve branded image from CDN
3 participants