Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate ISubscriberPayload in subscriber.interface #2157

Conversation

viktorlarsson
Copy link
Contributor

@viktorlarsson viktorlarsson commented Dec 2, 2022

What change does this PR introduce?

Duplicate identical IUpdateSubscriberPreferencePayload inside subscriber.interface.ts.

Why was this change needed?

While trying to investigate how Novu works, we stumbled upon this. Found by @milanarif

Other information (Screenshots)

image

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@p-fernandez p-fernandez merged commit 9cc86cb into novuhq:next Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants