This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Implement support for "may launch url" (single url) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused class
| public CustomTabsSession newSession() { | ||
| if (hasConnectedClient()) { | ||
| return client.newSession(); | ||
| public void mayLaunch(Uri url) { |
There was a problem hiding this comment.
uri would be a less confusing variable name here IMO, and at 🎱 too
|
Other than a little variable name change it all looks good to me. 👍 |
| * Starts a new session for Chrome Custom Tabs usage. Can be used to warmup particular Urls. | ||
| * Tells SimpleChromeCustomTabs that a potential Url might be launched. This will do pre DNS resolution that will speed things up. | ||
| * @param uri | ||
| * @return WebNavigator with warmed up url |
There was a problem hiding this comment.
You mention that this will return a WebNavigation, but this method in fact returns void
There was a problem hiding this comment.
oh lol, you are right thank you!
|
@joetimmins @alexstyl friends, comments addressed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Requested
To implement support for the function
mayLaunch(url)fromChromeCustomTabs. From Chrome Custom Tabs documentation:Solution implemented
Basically to make
Connectionresponsible for implementing themayLaunchfunctionality.In terms of implementation details, when someone does
SimpleChromeCustomTabsConnection.mayLaunch(url)then it will delegate to the current activeSession, which will invoke the method on the proxied classChromeCustomTabsSession. If at the time of calling the method there is no activeSessionthen theurlwill be saved for later, and will be warmed up (flagged as may launch) for when an activeSessionstarts.Test added [yes], about the new functionality.
Note Also renamed the tests to follow the same naming convention,
given_when_thenScreenshots
No UI Changes.