Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #10 - Having trouble building in Visual Studio 2015 #13

Merged
merged 3 commits into from
Jan 9, 2017

Conversation

fmigneault
Copy link
Contributor

Resolves issue #10

  • Change cmake SHARED to STATIC library to avoid linking error (.lib not found in MSVC as .dll gets created)
  • Adjust cmake file to avoid problematic linking when using MSVC (m.lib not required)
  • Move cmath header causing an issue under MSVC
  • Add dynamic array creation using standard C++ method

…2015

- Adjust cmake file to avoid problematic linking when using MSVC
- Move cmath header causing an issue under MSVC
- Add dynamic array creation using standard C++ method
@nourani nourani merged commit 4544eca into nourani:master Jan 9, 2017
@nourani
Copy link
Owner

nourani commented Jan 9, 2017

Awesome! Thanks for the fix @kenjikyo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants