Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched from notional-labs/ibc-go/v3 to cosmos/ibc-go/v3 #23

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

zavgorodnii
Copy link

@zavgorodnii zavgorodnii commented Apr 5, 2022

This PR replaces a custom upgrade to ibc v3 by notional labs to the "official" upgrade by the ibc-go team (cosmos/ibc-go#1205)

@faddat
Copy link

faddat commented Apr 6, 2022

thank you!

ya know I'd forgotten this step and it is important for sure.

@zavgorodnii
Copy link
Author

thank you!

ya know I'd forgotten this step and it is important for sure.

right! anything we forgot to include in this PR?

@faddat
Copy link

faddat commented Apr 11, 2022

No I think that this is correct.

I am sorry about the slow review: juno.

Copy link

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending review by @catShaark

@catShaark
Copy link

catShaark commented Apr 11, 2022

I think our update is flawed because we don't have the code to support ica for wasmd.

Copy link

@catShaark catShaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss

@faddat
Copy link

faddat commented Apr 11, 2022

@catShaark @oopcode would you guys mind having a look at branch ica-v3?

branch ica-v3 is:

  • sdk 45.2
  • tm 34.16

@catShaark we're about to deploy ica/cw to dig-- is there an issue?

tag: v0.25.0-ica

@faddat faddat merged commit 348f50a into notional-labs:fortysix Apr 11, 2022
@catShaark
Copy link

catShaark commented Apr 11, 2022

I'm putting an issue to ibc-go now, I will propose that they remove counterPartyPortID validation in ica host recv packet logic

@catShaark we're about to deploy ica/cw to dig-- is there an issue?

Issue now is cw no support ica, how about we ship without ica

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants