Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace time with std::time #114

Merged
merged 1 commit into from
Feb 26, 2017
Merged

Replace time with std::time #114

merged 1 commit into from
Feb 26, 2017

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Feb 26, 2017

Cargo will still pull time in as a dependency at times through mio, but mio 0.6 doesn't depend on time

@dfaust
Copy link
Collaborator

dfaust commented Feb 26, 2017

Thank you very much. I looked through the code and it looks good.

The biggest change I could find is that the poll watcher now uses the monotonic - but not steady - std::time::Instant instead of the high-resolution performance counter from time. This shouldn't change the behavior of the poll watcher, though, because the time is only used to compare last_check time-stamps. The polling interval is still set by thread::sleep().

@dfaust dfaust merged commit af142ef into notify-rs:master Feb 26, 2017
@passcod
Copy link
Member

passcod commented Feb 26, 2017

I'll release this as a patch-level change later this week, along with the deprecation from #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants