Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows appveyor build failing #43

Closed
jmquigs opened this issue Dec 5, 2015 · 5 comments
Closed

windows appveyor build failing #43

jmquigs opened this issue Dec 5, 2015 · 5 comments

Comments

@jmquigs
Copy link
Contributor

jmquigs commented Dec 5, 2015

Affects #40 but will also affect master when the next build is done. I thought this was due to the fact that appveyor had updated to VS2015 Update 1, but I did the same update on my system and don't see the problem.
note: LINK : fatal error LNK1181: cannot open input file 'ws2_32.lib'

full log:
https://ci.appveyor.com/project/passcod/rsnotify/build/1.0.18/job/82l87bwbob81dvag

@retep998, any ideas?

@retep998
Copy link

retep998 commented Dec 5, 2015

I'm on it. It appears to be due to appveyor having a newer windows 10 SDK which isn't supported yet.

@retep998
Copy link

retep998 commented Dec 6, 2015

rust-lang/rust#30229

jmquigs added a commit to jmquigs/rsnotify that referenced this issue Dec 6, 2015
@passcod
Copy link
Member

passcod commented Dec 6, 2015

@retep998 What's your recommendation, here: apply the temporary fix until the issue is fixed upstream, or wait for upstream?

@retep998
Copy link

retep998 commented Dec 6, 2015

It's up to you. The PR could take several days, especially due to potential bikeshedding on what the proper way to detect the SDK stuff is.

@jmquigs
Copy link
Contributor Author

jmquigs commented Dec 6, 2015

The vcvars fix seems safe enough, even after upstream is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants