Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify failing on MacOS with new fsevent-sys update #314

Closed
NathanSWard opened this issue May 12, 2021 · 4 comments · Fixed by #316
Closed

notify failing on MacOS with new fsevent-sys update #314

NathanSWard opened this issue May 12, 2021 · 4 comments · Fixed by #316
Labels

Comments

@NathanSWard
Copy link

System details

  • OS/Platform name and version: MacOS - latest
  • Rust version (if building from source): rustc --version: 1.52
  • Notify version (or commit hash if building from git):
    In Cargo.toml
    notify = { version = "5.0.0-pre.2", optional = true }

What you did (as detailed as you can)

On the bevy github page, our CI builds are failing due to a recent update within the fsevent-sys crate.
See CI failures here;

What you expected

No CI failure on a simple minor release version change.

What happened

CI failed due to:

error[E0308]: mismatched types
   --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/notify-5.0.0-pre.7/src/fsevent.rs:361:17
    |
361 |                 callback,
    |                 ^^^^^^^^ expected `u32`, found enum `c_void`
    |
    = note: expected fn pointer `extern "C" fn(_, _, _, _, *const u32, *const u64)`
                  found fn item `extern "C" fn(_, _, _, _, *const c_void, *const c_void) {callback}`
@NathanSWard
Copy link
Author

This could be fixed by changing the fsevent-sys version dependency to fsevent-sys = "3.1" in the Cargo.toml`.

[target.'cfg(target_os="macos")'.dependencies]
fsevent = "2.0.1"
fsevent-sys = "3.1"

@0xpr03
Copy link
Member

0xpr03 commented May 12, 2021

cc @erickt is this related to your recent PRs ?

@erickt
Copy link
Contributor

erickt commented May 12, 2021

@0xpr03 - yeah, it looks like the API change I made to fsevent was done in a minor version, rather than major API change. I'll submit a fix.

erickt added a commit to erickt/notify that referenced this issue May 12, 2021
The latest released fsevents 3.2 made a breaking change in a minor version.

Fixes notify-rs#314
0xpr03 pushed a commit that referenced this issue May 12, 2021
The latest released fsevents 3.2 made a breaking change in a minor version.

Fixes #314
@0xpr03
Copy link
Member

0xpr03 commented May 12, 2021

Released as 5.0.0-pre.8
v4 shouldn't be affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants