Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade circleci runners to ubuntu 22.04 #1645

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

jonnystoten
Copy link
Contributor

@jonnystoten jonnystoten commented Jun 7, 2022

ubuntu 16.04 runners went EOL on 2022-05-31, see https://circleci.com/blog/ubuntu-14-16-image-deprecation/. This PR updates to 22.04 runners.

I also had to remove a test that we can't bind the server to a privileged port because with the newer version of Docker that is installed on the new machine, we can. See moby/moby#41030 for details.

ubuntu 16.04 runners went EOL on 2022-05-31, see
https://circleci.com/blog/ubuntu-14-16-image-deprecation/

Signed-off-by: Jonny Stoten <[email protected]>
This succeeds now due to moby/moby#41030.

If this test fails it would hang the test process forever because the
Run function blocks if it is running successfully. Rewrite the other
similar test to timeout after a couple of seconds.

Signed-off-by: Jonny Stoten <[email protected]>
@jonnystoten jonnystoten marked this pull request as ready for review June 8, 2022 10:14
Copy link
Contributor

@bshaaban bshaaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justincormack justincormack merged commit 40969cc into notaryproject:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants