Merge pull request #1635 from kylewuolle/fix-role-parsing

Fix role parsing in golang 1.17+
notaryproject · May 31, 2022 · bc25fff · bc25fff
2 parents 0154426 + efc35b0
commit bc25fff
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/server/handlers/default.go b/server/handlers/default.go
@@ -6,6 +6,7 @@ import (
 	"encoding/hex"
 	"encoding/json"
 	"io"
+	"mime"
 	"net/http"
 	"strings"
 
@@ -72,7 +73,12 @@ func atomicUpdateHandler(ctx context.Context, w http.ResponseWriter, r *http.Req
 		if err == io.EOF {
 			break
 		}
-		role := data.RoleName(strings.TrimSuffix(part.FileName(), ".json"))
+		_, params, err := mime.ParseMediaType(part.Header.Get("Content-Disposition"))
+		if err != nil {
+			logger.Infof("400 POST error parsing Content-Disposition header: %s", err)
+			return errors.ErrNoFilename.WithDetail(nil)
+		}
+		role := data.RoleName(strings.TrimSuffix(params["filename"], ".json"))
 		if role.String() == "" {
 			logger.Info("400 POST empty role")
 			return errors.ErrNoFilename.WithDetail(nil)