Add function to RelayDelegate to receive all relay response types #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
commented
Jun 26, 2024
bryanmontz
approved these changes
Jun 26, 2024
tyiu
force-pushed
the
tyiu/relay-delegate-receive-all-response-types
branch
from
2cd9827
to
49e86c9
Compare
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this change is that there is currently no way for consumers of the library to reasonably manage their relay subscriptions.
For example, if they wanted to subscribe to events up to only what is stored on the relay, but they do not want to receive any new live events that come in, they will want to close their subscription after receiving an
EOSE(end of stored events) response rather than keeping the subscription perpetually open.By allowing folks to listen on all types of relay responses (not just ones with Nostr events), it provides more flexibility to the developer in maintaining the state of their application.
mainafter the above PR is merged