Rename SetMetadataEvent to MetadataEvent to conform to current NIPs repository #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
approved these changes
May 29, 2024
bryanmontz
force-pushed
the
tyiu/rename-set-metadata
branch
from
b93ba66
to
f23275a
Compare
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR introduces breaking changes.
The NIPs repo renamed it, and "set metadata" never made sense for me as a term. "Is set a noun or verb?" is the first thing I think about each time I come across it.