Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NIP-59 gift wraps #156

Merged
merged 3 commits into from
May 28, 2024
Merged

Add support for NIP-59 gift wraps #156

merged 3 commits into from
May 28, 2024

Conversation

tyiu
Copy link
Contributor

@tyiu tyiu commented May 18, 2024

NIP-59 - Gift Wrap

This PR introduces two new kinds:

  • Kind 13: seal
  • Kind 1059: gift wrap

This PR also contains a breaking change where signature on NostrEvent is now optional to accommodate unsigned events (aka rumors).

After this change gets in, we will be unblocked with implementing NIP -17 - Private Direct Messages.

@tyiu tyiu requested review from joelklabo and bryanmontz May 18, 2024 14:06
Sources/NostrSDK/Events/GiftWrap/GiftWrapEvent.swift Outdated Show resolved Hide resolved
Sources/NostrSDK/Events/GiftWrap/GiftWrapEvent.swift Outdated Show resolved Hide resolved
Sources/NostrSDK/Events/GiftWrap/GiftWrapEvent.swift Outdated Show resolved Hide resolved
Sources/NostrSDK/Events/GiftWrap/GiftWrapEvent.swift Outdated Show resolved Hide resolved
Sources/NostrSDK/Events/GiftWrap/SealEvent.swift Outdated Show resolved Hide resolved
@tyiu tyiu requested a review from bryanmontz May 28, 2024 03:26
@bryanmontz bryanmontz merged commit ea539cc into main May 28, 2024
4 checks passed
@bryanmontz bryanmontz deleted the nip-59 branch May 28, 2024 12:16
RandyMcMillan pushed a commit to RandyMcMillan/nostr-sdk-ios that referenced this pull request Sep 1, 2024
* Add support for NIP-59 gift wraps

* Apply suggestions from code review

Co-authored-by: Bryan Montz <[email protected]>

* Fix callsites to GiftWrapEvent and SealEvent functions that were renamed

---------

Co-authored-by: Bryan Montz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants