-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and add tag interpreters for identifiers, titles, relays, and replaceable events #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
force-pushed
the
tyiu/tags-refactor
branch
3 times, most recently
from
December 17, 2023 02:01
c849115
to
c1ccb5a
Compare
tyiu
changed the title
Refactor tag interpreters for identifiers and titles and add event coordinates tag interpreter
Refactor and add tag interpreters for identifiers, titles, relays, and replaceable events
Dec 17, 2023
tyiu
commented
Dec 17, 2023
bryanmontz
reviewed
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tyiu!
…d replaceable events
Co-authored-by: Bryan Montz <[email protected]>
tyiu
force-pushed
the
tyiu/tags-refactor
branch
from
December 18, 2023 02:29
86355e1
to
c1b5b61
Compare
bryanmontz
approved these changes
Dec 19, 2023
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
…d replaceable events (nostr-sdk#119) * Refactor and add tag interpreters for identifiers, titles, relays, and replaceable events * Apply suggestions from code review Co-authored-by: Bryan Montz <[email protected]> * Rename replaceableEvent tag to eventCoordinates to conform to wording in spec * Address code review feedback on ReplaceableEventCoordinates * Move relay validation logic to RelayURLValidating --------- Co-authored-by: Bryan Montz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.