Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tag interpreters for identifiers, titles, relays, and replaceable events #119

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

tyiu
Copy link
Contributor

@tyiu tyiu commented Dec 16, 2023

No description provided.

@tyiu tyiu force-pushed the tyiu/tags-refactor branch 3 times, most recently from c849115 to c1ccb5a Compare December 17, 2023 02:01
@tyiu tyiu changed the title Refactor tag interpreters for identifiers and titles and add event coordinates tag interpreter Refactor and add tag interpreters for identifiers, titles, relays, and replaceable events Dec 17, 2023
@tyiu tyiu marked this pull request as ready for review December 17, 2023 02:02
@tyiu tyiu requested a review from bryanmontz December 17, 2023 02:03
Copy link
Collaborator

@bryanmontz bryanmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tyiu!

Sources/NostrSDK/Events/GenericRepostEvent.swift Outdated Show resolved Hide resolved
Sources/NostrSDK/Helpers/String+Additions.swift Outdated Show resolved Hide resolved
Sources/NostrSDK/Tag.swift Outdated Show resolved Hide resolved
@tyiu tyiu requested a review from bryanmontz December 18, 2023 15:50
@bryanmontz bryanmontz merged commit 91b899f into main Dec 19, 2023
4 checks passed
@bryanmontz bryanmontz deleted the tyiu/tags-refactor branch December 19, 2023 12:54
RandyMcMillan pushed a commit to RandyMcMillan/nostr-sdk-ios that referenced this pull request Sep 1, 2024
…d replaceable events (nostr-sdk#119)

* Refactor and add tag interpreters for identifiers, titles, relays, and replaceable events

* Apply suggestions from code review

Co-authored-by: Bryan Montz <[email protected]>

* Rename replaceableEvent tag to eventCoordinates to conform to wording in spec

* Address code review feedback on ReplaceableEventCoordinates

* Move relay validation logic to RelayURLValidating

---------

Co-authored-by: Bryan Montz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants